Fix for Dockerfile smell DL3009 - #886
Closed
Giovanni Rosa (grosa1) wants to merge 1 commit into
Closed
Conversation
Signed-off-by: Giovanni Rosa <g.rosa1@studenti.unimol.it>
Giovanni Rosa (grosa1)
requested review from
CooperLink,
Tsuyoshi Ushio (TsuyoshiUshio),
Jameson Z (VpOfEngineering),
Ahmed ElSayed (ahmelsayed),
Ahmed El Sayed (amamounelsayed),
Anirudh Garg (anirudhgarg),
Bala G (balag0),
Pragna Gopa (pragnagopa) and
Varad Meru (vrdmr)
as code owners
April 14, 2023 23:43
Giovanni Rosa (grosa1)
requested a review
from Tony Choi (Tonewall)
as a code owner
November 27, 2023 21:20
Collaborator
|
Thank you for taking the time to contribute. As noted in the repository README, the Azure Functions base-image Dockerfile sources were moved to an internal Microsoft repository in May 2025 and are no longer maintained here. The files and directories targeted by this pull request have therefore been removed, so this change can no longer be merged. We are closing this pull request as part of cleaning up the repository. This repository will remain available for supported samples and GitHub issues. If the proposed change identifies a problem with a published image or Azure Functions behavior, please open or continue an issue with the relevant details. We appreciate your contribution and understanding. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Hi!
The Dockerfile placed at "host/4/bullseye/amd64/node/node16/node16-slim.Dockerfile" contains the best practice violation DL3009 detected by the hadolint tool.
The smell DL3009 occurs when the apt tool is used to install packages without wiping the cache and source lists.
This pull request proposes a fix for that smell generated by my fixing tool. The generated patch has been manually verified before opening the pull request.
To fix this smell, specifically, the instructions to clean up the apt cache and remove the /var/lib/apt/lists have been added. This helps keep the image size down.
This change is only aimed at fixing that specific smell. If the fix is not valid or useful, please briefly indicate the reason and suggestions for possible improvements.
Thanks in advance
PR information